gyfora commented on code in PR #223:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/223#discussion_r876580526
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkUtils.java:
##########
@@ -245,9 +245,19 @@ public static void deleteJobGraphInKubernetesHA(
}
public static boolean isHaMetadataAvailable(
- Configuration conf, KubernetesClient kubernetesClient) {
- String clusterId = conf.get(KubernetesConfigOptions.CLUSTER_ID);
- String namespace = conf.get(KubernetesConfigOptions.NAMESPACE);
+ Configuration observeConfig,
+ Configuration deployConfig,
+ KubernetesClient kubernetesClient) {
+
+ if (!FlinkUtils.isKubernetesHAActivated(observeConfig)
Review Comment:
you are right, I will try to clean this up and keep it in the
getAvailableUpgrade mode where it covers a special cornercase for the savpeoint
upgrade mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
