snuyanzin commented on code in PR #19753:
URL: https://github.com/apache/flink/pull/19753#discussion_r876970913
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/CurrentWatermarkTypeStrategyTest.java:
##########
@@ -26,21 +26,12 @@
import org.apache.flink.table.types.logical.TimestampType;
import org.apache.flink.table.types.utils.TypeConversions;
-import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.MethodSource;
-
import java.util.stream.Stream;
/** Tests for {@link CurrentWatermarkTypeStrategy}. */
class CurrentWatermarkTypeStrategyTest extends TypeStrategiesTestBase {
- @ParameterizedTest(name = "{index}: {0}")
- @MethodSource("testData")
- protected void testTypeStrategy(TestSpec testSpec) {
- super.testTypeStrategy(testSpec);
- }
-
- static Stream<TestSpec> testData() {
+ protected Stream<TestSpec> testData() {
Review Comment:
yes, you're right, thanks
added missing `@Override`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
