yangjunhan commented on code in PR #19712:
URL: https://github.com/apache/flink/pull/19712#discussion_r879269798
##########
flink-runtime-web/web-dashboard/src/app/pages/job-manager/log-detail/job-manager-log-detail.component.ts:
##########
@@ -35,20 +40,24 @@ import { EditorOptions } from
'ng-zorro-antd/code-editor/typings';
styleUrls: ['./job-manager-log-detail.component.less']
})
export class JobManagerLogDetailComponent implements OnInit, OnDestroy {
+ public editorOptions: EditorOptions;
public logs = '';
public logName = '';
public downloadUrl = '';
public isLoading = false;
public isFullScreen = false;
- public editorOptions: EditorOptions = flinkEditorOptions;
private readonly destroy$ = new Subject<void>();
constructor(
private readonly jobManagerService: JobManagerService,
private readonly cdr: ChangeDetectorRef,
- private readonly activatedRoute: ActivatedRoute
- ) {}
+ private readonly activatedRoute: ActivatedRoute,
+ private readonly configService: ConfigService,
+ @Inject(JOB_MANAGER_MODULE_CONFIG) readonly moduleConfig:
JobManagerModuleConfig
+ ) {
+ this.editorOptions = moduleConfig.editorOptions ||
JOB_MANAGER_MODULE_DEFAULT_CONFIG.editorOptions;
Review Comment:
This is because `editorOptions` can be omitted if someone overrides the
whole `moduleConfig` through the token.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
