wolfboys opened a new pull request, #19798:
URL: https://github.com/apache/flink/pull/19798
## What is the purpose of the change
When I am running a flink job, I specify a running parameter with a "#" sign
in it. The parsing fails.
e.g: flink run com.myJob --sink.password db@123#123
only parse the content in front of "#", after reading the source code It is
found that the parameters are intercepted according to "#" in the
loadYAMLResource method of GlobalConfiguration. This part needs to be improved
## Brief change log
- before: `line.split("#", 2) ` after: `line.split("\\s+#", 2)` Following
yaml's parameter parsing rules, the content after " #" ( space + #) is the real
comment part, which should be discarded when parsing parameters
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): don't know
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
