tisonkun commented on code in PR #243: URL: https://github.com/apache/flink-kubernetes-operator/pull/243#discussion_r880657077
########## Dockerfile: ########## @@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/ COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src COPY $WEBHOOK_DIR/src ./$WEBHOOK_DIR/src -COPY .git ./.git +COPY *.git ./.git Review Comment: I confirm that this patch works also. My comment above is not about correctness - it's about documenting the trick. ########## Dockerfile: ########## @@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/ COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src COPY $WEBHOOK_DIR/src ./$WEBHOOK_DIR/src -COPY .git ./.git +COPY *.git ./.git Review Comment: I'm unsure whether this line can possibly pollute unexpected files. At least we should add a comment about this trick - it's a workaround since Dockerfile doesn't support conditional copy directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
