[
https://issues.apache.org/jira/browse/FLINK-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446144#comment-15446144
]
ASF GitHub Bot commented on FLINK-4496:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2434#discussion_r76624854
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/DefaultTimeServiceProvider.java
---
@@ -28,15 +31,22 @@
*/
public class DefaultTimeServiceProvider extends TimeServiceProvider {
+ /** The containing task that owns this time service provider. */
+ private final StreamTask<?, ?> task;
--- End diff --
If the `StreamTask` is only used for the async exception handling then I
think this can be abstracted behind an `AsynchronousExceptionHandler` interface
that the task implements. This would have something like
`notifyOfAsyncException()` and `checkAsyncExceptions()`. These are the same
methods that `StreamTask` has now but we would not expose all of `StreamTask`
to the time service provider but have clear-cut interfaces.
> Refactor the TimeServiceProvider to take a Trigerable instead of a Runnable.
> ----------------------------------------------------------------------------
>
> Key: FLINK-4496
> URL: https://issues.apache.org/jira/browse/FLINK-4496
> Project: Flink
> Issue Type: Sub-task
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
