morhidi commented on code in PR #244:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/244#discussion_r883354595
##########
flink-kubernetes-webhook/pom.xml:
##########
@@ -36,6 +36,19 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-kubernetes-operator</artifactId>
<version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>io.javaoperatorsdk</groupId>
+ <artifactId>operator-framework-framework-core</artifactId>
+ <version>${operator.sdk.admission-controller.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
Review Comment:
The admission-controller-framework is depending on an older
`io.fabric8:kubernetes-client`. It had some collisions with the newer version
that we put on the class-path with the the operator-shaded jar. Since this code
worked in the operator before, it seemed safe to remove the dependencies and
use them from the operator class-path. Hopefully the validation framework will
merge with the operator sdk and share the dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
