mbalassi commented on code in PR #246:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/246#discussion_r884046691
##########
helm/flink-kubernetes-operator/templates/flink-operator.yaml:
##########
@@ -34,6 +34,12 @@ spec:
{{- include "flink-operator.selectorLabels" . | nindent 8 }}
annotations:
kubectl.kubernetes.io/default-container: {{ .Chart.Name }}
+ {{- $keyExist := .Values.operatorPodDeployment | default dict -}}
Review Comment:
This could be just `if .Values.operatorPodDeployment.annotations`, right?
We are using the same convention throughout the helm chart.
##########
helm/flink-kubernetes-operator/values.yaml:
##########
@@ -30,6 +30,9 @@ image:
rbac:
create: true
+operatorPodDeployment:
Review Comment:
I find the name confusing. Is it for the pod or the deployment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
