yunfengzhou-hub commented on code in PR #97: URL: https://github.com/apache/flink-ml/pull/97#discussion_r884536704
########## flink-ml-iteration/src/main/java/org/apache/flink/iteration/datacache/nonkeyed/MemorySegmentWriter.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.iteration.datacache.nonkeyed; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.core.fs.Path; +import org.apache.flink.runtime.memory.MemoryAllocationException; +import org.apache.flink.runtime.memory.MemoryManager; +import org.apache.flink.runtime.memory.MemoryReservationException; +import org.apache.flink.util.Preconditions; + +import org.openjdk.jol.info.GraphLayout; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Optional; + +/** A class that writes cache data to memory segments. */ +@Internal +public class MemorySegmentWriter<T> implements SegmentWriter<T> { + private final Segment segment; + + private final MemoryManager memoryManager; + + public MemorySegmentWriter(Path path, MemoryManager memoryManager) + throws MemoryAllocationException { + this(path, memoryManager, 0L); + } + + public MemorySegmentWriter(Path path, MemoryManager memoryManager, long expectedSize) + throws MemoryAllocationException { + Preconditions.checkNotNull(memoryManager); + this.segment = new Segment(); + this.segment.path = path; + this.segment.cache = new ArrayList<>(); + this.segment.inMemorySize = 0L; + this.memoryManager = memoryManager; + } + + @Override + public boolean addRecord(T record) throws IOException { + if (!MemoryUtils.isMemoryEnoughForCache(memoryManager)) { + return false; + } + + long recordSize = GraphLayout.parseInstance(record).totalSize(); Review Comment: According to offline discussion, I'll store serialized format of the records in memory, so there is no need for size estimation now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
