alpreu commented on code in PR #19808:
URL: https://github.com/apache/flink/pull/19808#discussion_r884696823
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java:
##########
@@ -82,14 +82,16 @@ public void testKeyValueDeserializersSetIfMissing() throws
Exception {
new DummyFlinkKafkaProducer<>(
props, new KeyedSerializationSchemaWrapper<>(new
SimpleStringSchema()), null);
-
assertTrue(props.containsKey(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG));
-
assertTrue(props.containsKey(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG));
- assertTrue(
- props.getProperty(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG)
- .equals(ByteArraySerializer.class.getName()));
- assertTrue(
- props.getProperty(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG)
- .equals(ByteArraySerializer.class.getName()));
+
assertThat(props).containsKey(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG);
+
assertThat(props).containsKey(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG);
+ assertThat(
+
props.getProperty(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG)
+ .equals(ByteArraySerializer.class.getName()))
+ .isTrue();
+ assertThat(
+
props.getProperty(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG)
+ .equals(ByteArraySerializer.class.getName()))
+ .isTrue();
Review Comment:
Good catch, looks like this was a broken test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
