[ 
https://issues.apache.org/jira/browse/FLINK-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449347#comment-15449347
 ] 

ASF GitHub Bot commented on FLINK-4347:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2388#discussion_r76821672
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotID.java
 ---
    @@ -75,9 +75,15 @@ public int hashCode() {
     
        @Override
        public String toString() {
    -           return "SlotID{" +
    -                   "resourceId=" + resourceId +
    -                   ", slotId=" + slotId +
    -                   '}';
    +           return resourceId + "_" + slotId;
    --- End diff --
    
    Why do you change the existing `toString()` method?


> Implement SlotManager core
> --------------------------
>
>                 Key: FLINK-4347
>                 URL: https://issues.apache.org/jira/browse/FLINK-4347
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Kurt Young
>            Assignee: Kurt Young
>
> The slot manager is responsible to maintain the list of slot requests and 
> slot allocations. It allows to request slots from the registered 
> TaskExecutors and issues container allocation requests in case that there are 
> not enough available resources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to