gyfora commented on code in PR #252:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889524444
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java:
##########
@@ -274,6 +279,15 @@ public void
verifyInProgressDeploymentWithCrashLoopBackoff() throws Exception {
validatingResponseProvider.assertValidated();
}
+ @ParameterizedTest
+ @EnumSource(FlinkVersion.class)
+ public void cleanUpDeploymentWithError(FlinkVersion flinkVersion)
+ throws JsonProcessingException {
+ FlinkDeployment flinkDeployment = TestUtils.buildApplicationCluster();
+ val deleteControl = testController.cleanup(flinkDeployment, context);
Review Comment:
We generally don’t use this and also avoid final variables in these cases as
it doesn’t affect anything only adds boilerplate on these cases.
also we should restrict Lombok usage where it adds significant tangible
value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
