Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2388#discussion_r76822478
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotID.java
 ---
    @@ -75,9 +75,15 @@ public int hashCode() {
     
        @Override
        public String toString() {
    -           return "SlotID{" +
    -                   "resourceId=" + resourceId +
    -                   ", slotId=" + slotId +
    -                   '}';
    +           return resourceId + "_" + slotId;
    +   }
    +
    +   /**
    +    * Generate a random slot id.
    +    *
    +    * @return A random slot id.
    +    */
    +   public static SlotID generate() {
    +           return new SlotID(ResourceID.generate(), 0);
    --- End diff --
    
    This always generates the same slot id. At this point I'm not really sure 
what the purpose of the slot id is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to