[ 
https://issues.apache.org/jira/browse/FLINK-27710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551468#comment-17551468
 ] 

Xintong Song commented on FLINK-27710:
--------------------------------------

I'm not entirely sure about the format.

An execution is uniquely identified by <graph-id, vertex-id, subtask-index, 
attempt-id>. I'm concerned that for someone how is not super familiar with the 
Flink internal concepts, they may misunderstand the vertex-id as the unique 
identifier of a task.

I'm leaning towards keeping it as is, displaying the complete execution id. It 
prevents confusions, at the cost of being a little verbose which IMO is fine.

> Improve logs to better display Execution
> ----------------------------------------
>
>                 Key: FLINK-27710
>                 URL: https://issues.apache.org/jira/browse/FLINK-27710
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination, Runtime / Task
>    Affects Versions: 1.16.0
>            Reporter: Zhu Zhu
>            Assignee: Zhu Zhu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.16.0
>
>
> Currently, an execution is usually represented as "{{{}job vertex name{}}} 
> ({{{}subtaskIndex+1{}}}/{{{}vertex parallelism{}}}) ({{{}attemptId{}}})" in 
> logs, which may be redundant after this refactoring work. With the change of 
> FLINK-17295, the representation of Execution in logs will be redundant. e.g. 
> the subtask index is displayed 2 times.
> Therefore, I'm proposing to change the format to be "<{{{}job vertex name> 
> {{}}}}(<{{{}subtaskIndex>+1{}}}/<{{{}vertex parallelism>{}}}) 
> {{#<attemptNumber>}}  (graph: <{{{}short ExecutionGraphID>, vertex: 
> <{}}}{{{}JobVertexID>{}}}) " and avoid directly display the 
> {{{}ExecutionAttemptID{}}}. This can increase the log readability.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to