lsyldliu commented on code in PR #19742:
URL: https://github.com/apache/flink/pull/19742#discussion_r894986764
##########
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java:
##########
@@ -1324,15 +1324,26 @@ void testCreateFunction() {
.ok(
"CREATE TEMPORARY FUNCTION `FUNCTION1` AS
'org.apache.fink.function.function1' LANGUAGE SCALA USING JAR
'/path/to/test.jar'");
+ sql("create temporary system function function1 as
'org.apache.fink.function.function1' language scala using jar
'/path/to/test.jar'")
+ .ok(
+ "CREATE TEMPORARY SYSTEM FUNCTION `FUNCTION1` AS
'org.apache.fink.function.function1' LANGUAGE SCALA USING JAR
'/path/to/test.jar'");
+
sql("create function function1 as 'org.apache.fink.function.function1'
language java using jar 'file:///path/to/test.jar', jar
'hdfs:///path/to/test2.jar'")
.ok(
"CREATE FUNCTION `FUNCTION1` AS
'org.apache.fink.function.function1' LANGUAGE JAVA USING JAR
'file:///path/to/test.jar', JAR 'hdfs:///path/to/test2.jar'");
- sql("create temporary function function1 as
'org.apache.fink.function.function1' language sql using jar
'file:///path/to/test.jar'")
- .fails("USING JAR syntax is not applicable to SQL language.");
+ sql("create temporary function function1 as
'org.apache.fink.function.function1' language sql ^using^ jar
'file:///path/to/test.jar'")
+ .fails("CREATE FUNCTION USING JAR syntax is not applicable to
SQL language.");
- sql("create temporary function function1 as
'org.apache.fink.function.function1' language python using jar
'file:///path/to/test.jar'")
- .fails("USING JAR syntax is not applicable to PYTHON
language.");
+ sql("create temporary function function1 as
'org.apache.fink.function.function1' language python ^using^ jar
'file:///path/to/test.jar'")
Review Comment:
Good catch, I have fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
