Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r77310357
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/PartialInputChannelDeploymentDescriptor.java
---
@@ -44,15 +44,15 @@
private final ResultPartitionID partitionID;
/** The partition connection info. */
- private final InstanceConnectionInfo partitionConnectionInfo;
+ private final TaskManagerLocation partitionConnectionInfo;
/** The partition connection index. */
private final int partitionConnectionIndex;
public PartialInputChannelDeploymentDescriptor(
IntermediateDataSetID resultId,
ResultPartitionID partitionID,
- InstanceConnectionInfo partitionConnectionInfo,
+ TaskManagerLocation partitionConnectionInfo,
--- End diff --
Shall we adapt the variable names as well? Otherwise it might be a little
confusing that a `partitionConnectionInfo` is actually of type
`TaskManagerLocation`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
