zhuzhurk commented on code in PR #20080:
URL: https://github.com/apache/flink/pull/20080#discussion_r907290772
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionVertex.java:
##########
@@ -100,13 +99,12 @@ public TaskManagerLocation
getCurrentAssignedResourceLocation() {
return currentExecution.getAssignedResourceLocation();
}
- @Nullable
@Override
- public ArchivedExecution getPriorExecutionAttempt(int attemptNumber) {
- if (attemptNumber >= 0 && attemptNumber < priorExecutions.size()) {
- return priorExecutions.get(attemptNumber);
- } else {
- throw new IllegalArgumentException("attempt does not exist");
- }
+ public ExecutionHistory getExecutionHistory() {
+ return executionHistory;
+ }
+
+ static ExecutionHistory getCopyOfExecutionHistory(ExecutionVertex
executionVertex) {
Review Comment:
It will be used by `ArchivedSpeculativeExecutionVertex` in a latter
pr(#20082), I would keep its default scope to avoid back&forth changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
