zhuzhurk commented on code in PR #20056:
URL: https://github.com/apache/flink/pull/20056#discussion_r910557929


##########
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptionsInternal.java:
##########
@@ -32,4 +32,15 @@ public class TaskManagerOptionsInternal {
                     .noDefaultValue()
                     .withDescription(
                             "**DO NOT USE** The metadata of TaskManager's 
ResourceID to be used for logging.");
+
+    /**
+     * The ID of the node where the TaskManager is located. In Yarn and Native 
Kubernetes mode, this
+     * option will be set by resource manager when launch a container for the 
task executor. In
+     * other modes, this option will not be set. This option is only used 
internally.
+     */
+    public static final ConfigOption<String> TASK_MANAGER_NODE_ID =
+            key("internal.taskmanager.node-id")
+                    .stringType()
+                    .noDefaultValue()
+                    .withDescription("ID of the node where the TaskManager is 
located.");

Review Comment:
   Both look good to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to