xintongsong commented on code in PR #20142:
URL: https://github.com/apache/flink/pull/20142#discussion_r912612048
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/DashboardConfiguration.java:
##########
@@ -139,6 +146,11 @@ public boolean isWebCancelEnabled() {
return webCancelEnabled;
}
+ @JsonIgnore
+ public boolean isWebHistoryEnabled() {
Review Comment:
I think the name is misleading. Unlike `isWebSubmitEnabled` and
`isWebCancelEnabled` which indicate whether a feature is enabled, this
indicates whether the dashboard is served by a running cluster or a history
server. I'd suggest the name `isHistoryServer`.
Same for the relevant field/variable/method names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
