[ 
https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464917#comment-15464917
 ] 

ASF GitHub Bot commented on FLINK-4458:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2450
  
    I've re-introduced the `ForkableFlinkMiniCluster`. However, this time it 
only starts the normal distributed component classes (e.g. `JobManager` instead 
of `TestingJobManager`, etc.). This implies that the testing messages are no 
longer supported when using the `ForkableFlinkMiniCluster`.
    
    I think the user should not meddle with the testing components in the first 
place. Therefore, it seems to be fair to offer the user a mini cluster to run 
his tests but not one which instantiates testing components. The recommended 
cluster is the `LocalFlinkMiniCluster` from now on. However, in order to not 
break all existing test code, we still maintain the `ForkableFlinkMiniCluster`.
    
    Not having to start the testing classes allows to move them back into the 
test scope of `flink-runtime`, since they are no longer required by the 
`flink-test-utils` module.


> Remove ForkableFlinkMiniCluster
> -------------------------------
>
>                 Key: FLINK-4458
>                 URL: https://issues.apache.org/jira/browse/FLINK-4458
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> After addressing FLINK-4424 we should be able to get rid of the 
> {{ForkableFlinkMiniCluster}} since we no longer have to pre-determine a port 
> in Flink. Thus, by setting the ports to {{0}} and letting the OS choose a 
> free port, there should no longer be conflicting port requests. Consequently, 
> the {{ForkableFlinkMiniCluster}} will become obsolete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to