LadyForest commented on code in PR #182:
URL: https://github.com/apache/flink-table-store/pull/182#discussion_r915536943
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/AppendOnlyWriter.java:
##########
@@ -88,6 +81,9 @@ public void write(RowData rowData) throws Exception {
"Append-only writer can only accept insert row kind, but
current row kind is: %s",
rowData.getRowKind());
writer.write(rowData);
+ if (!toCompact.isEmpty()) {
+ submitCompaction();
Review Comment:
Actually, the criteria for compaction are actively evaluated (as you say,
per record to check `toCompact` and submit if not empty), but the true
compaction rewrite frequency is unchanged. I'm both ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
