[GitHub] [flink] syhily commented on a diff in pull request #19972: [FLINK-27399][Connector/Pulsar] Change initial consuming position setting logic for better handle the checkpoint.

[GitBox]

syhily commented on code in PR #19972:
URL: https://github.com/apache/flink/pull/19972#discussion_r915990147


##########
flink-python/pyflink/datastream/connectors/pulsar.py:
##########
@@ -138,10 +138,10 @@ def latest() -> 'StartCursor':
         return StartCursor(JStartCursor.latest())
 
     @staticmethod
-    def from_message_time(timestamp: int) -> 'StartCursor':
+    def from_publish_time(timestamp: int) -> 'StartCursor':

Review Comment:
   Add this breaking change may not sound like a good choice. I add a new 
method and deprecated the old ones.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org