gaborgsomogyi commented on code in PR #20206: URL: https://github.com/apache/flink/pull/20206#discussion_r917747372
########## flink-runtime/src/main/java/org/apache/flink/runtime/security/token/HBaseDelegationTokenProvider.java: ########## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.security.token; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.runtime.util.HadoopUtils; +import org.apache.flink.util.Preconditions; + +import org.apache.hadoop.security.Credentials; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.security.token.Token; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.Closeable; +import java.io.IOException; +import java.lang.reflect.InvocationTargetException; +import java.util.Objects; +import java.util.Optional; + +/** Delegation token provider implementation for HBase. */ +public class HBaseDelegationTokenProvider implements DelegationTokenProvider { + + private static final Logger LOG = LoggerFactory.getLogger(HBaseDelegationTokenProvider.class); + + org.apache.hadoop.conf.Configuration hbaseConf; + + @Override + public String serviceName() { + return "hbase"; + } + + @Override + public void init(Configuration configuration) throws Exception { + hbaseConf = getHBaseConfiguration(configuration); + } + + private org.apache.hadoop.conf.Configuration getHBaseConfiguration(Configuration conf) { + org.apache.hadoop.conf.Configuration hbaseConf = null; + try { + org.apache.hadoop.conf.Configuration hadoopConf = + HadoopUtils.getHadoopConfiguration(conf); + // ---- + // Intended call: HBaseConfiguration.create(conf); + hbaseConf = + (org.apache.hadoop.conf.Configuration) + Class.forName("org.apache.hadoop.hbase.HBaseConfiguration") + .getMethod("create", org.apache.hadoop.conf.Configuration.class) Review Comment: This is not needed to be changed now so just asking. Why do we need reflection here? `HBaseConfiguration.create` is added in version 0.90.0 which is ancient version since the latest is 3.1.3. All in all if we support versions where the API must be there then we can drop the reflection in another PR, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
