fredia commented on code in PR #20217: URL: https://github.com/apache/flink/pull/20217#discussion_r920054435
########## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/DuplicatingOutputStreamWithPos.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.changelog.fs; + +import org.apache.flink.runtime.state.DuplicatingCheckpointOutputStream; +import org.apache.flink.util.Preconditions; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.io.OutputStream; + +/** + * A DuplicatingOutputStreamWithPos is similar to {@link DuplicatingCheckpointOutputStream} which + * wraps a primary and a secondary OutputStream and duplicates all writes into both streams. The + * difference is that this stream does not delete the file when {@link #close()}. + */ +class DuplicatingOutputStreamWithPos extends OutputStreamWithPos { Review Comment: Because compression is needed in changelog, but `CheckpointStateOutputStream` only offers the constructor with `FileBasedStateOutputStream(FileSystem fileSystem, Path path)` instead of `OutputStream`, we can't wrap the `OutputStream` with `StreamCompressionDecorator` in it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
