[ 
https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472686#comment-15472686
 ] 

ASF GitHub Bot commented on FLINK-4538:
---------------------------------------

Github user beyond1920 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2463#discussion_r77943543
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
 ---
    @@ -52,15 +58,28 @@
      * </ul>
      */
     public class ResourceManager extends RpcEndpoint<ResourceManagerGateway> {
    -   private final Map<JobMasterGateway, InstanceID> jobMasterGateways;
    +
    +   private final Logger LOG = LoggerFactory.getLogger(getClass());
    --- End diff --
    
    There is a log field in RpcEndpoint, which is protected, why not use that 
instead?


> Implement slot allocation protocol with JobMaster
> -------------------------------------------------
>
>                 Key: FLINK-4538
>                 URL: https://issues.apache.org/jira/browse/FLINK-4538
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to