xinbinhuang commented on code in PR #20289:
URL: https://github.com/apache/flink/pull/20289#discussion_r922925804


##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplitEnumerator.java:
##########
@@ -224,7 +226,9 @@ public void handleSourceEvent(int subtaskId, SourceEvent 
sourceEvent) {
             }
 
             // track readers that have finished processing for current 
enumerator
+            // TODO: should finishedReaders be reset after switching to a new 
numerator?

Review Comment:
   @tweise It seems that `finishedReaders` will keep increasing after the first 
switch unless the job is restarted. So if there are more than 2 sources in the 
chain, the 3rd and latter source may never get triggered. Is my understand 
correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to