[GitHub] [flink] rkhachatryan commented on a diff in pull request #19907: [FLINK-27692][state] Support local recovery for materialized part of changelog

[GitBox]

rkhachatryan commented on code in PR #19907:
URL: https://github.com/apache/flink/pull/19907#discussion_r926707252


##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java:
##########
@@ -686,12 +688,25 @@ public CompletableFuture<Acknowledge> submitTask(
             PartitionProducerStateChecker partitionStateChecker =
                     jobManagerConnection.getPartitionStateChecker();
 
+            // Configuration from application will override the one from env.
+            boolean envChangelogEnabled =
+                    taskManagerConfiguration
+                            .getConfiguration()

Review Comment:
   I meant something like this:
   ```
   // in TaskExecutor
   final TaskLocalStateStore localStateStore =
       localStateStoresManager.localStateStoreForSub
           jobId,
           tdd.getAllocationId(),
           taskInformation.getJobVertexId(),
           tdd.getSubtaskIndex(),
           taskManagerConfiguration.getConfigura
           jobInformation.getJobConfiguration())
   
   // TaskExecutorLocalStateStoresManager.localStateStoreForSubtask
       ...
       boolean changelogEnabled =
           jobConfiguration
               .getOptional(
                   StateChangelogOptionsInternal
                       .ENABLE_CHANGE_LOG_FOR_APPLICATION)
               .orElse(
                   clusterConfiguration.getBoolean(
                       StateChangelogOptions.ENABLE_STATE_CHANGE_LOG));
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org