dannycranmer commented on code in PR #20338:
URL: https://github.com/apache/flink/pull/20338#discussion_r927373779
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java:
##########
@@ -170,30 +170,30 @@
* the valid limits of the destination). The logic then needs to create
and execute the request
* asynchronously against the destination (ideally by batching together
multiple request entries
* to increase efficiency). The logic also needs to identify individual
request entries that
- * were not persisted successfully and resubmit them using the {@code
requestResult} callback.
+ * were not persisted successfully and resubmit them using the {@code
requestToRetry} callback.
Review Comment:
I understand the Jira said `requestToRetry`, but given this is a `List<>` I
think a better name would be `requestsToRetry`, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
