beyond1920 commented on code in PR #20361:
URL: https://github.com/apache/flink/pull/20361#discussion_r929884249


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -461,6 +463,23 @@ public boolean dropTemporaryFunction(String path) {
         return 
functionCatalog.dropTemporaryCatalogFunction(unresolvedIdentifier, true);
     }
 
+    @Override
+    public void addJar(String jarPath) {
+        try {
+            resourceManager.registerJarResources(
+                    Collections.singletonList(new 
ResourceUri(ResourceType.JAR, jarPath)));
+        } catch (IOException e) {
+            throw new TableException(String.format("Could not register the 
specified jar [%s].", jarPath), e);
+        }
+    }
+
+    @Override
+    public List<String> listJars() {

Review Comment:
   AddJar and listJars could work for TableAPI user.
   How to use this function for SQL user?
   We also need to support `AddJarOperation` in `executeInternal` method, WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to