[GitHub] [flink] rkhachatryan commented on a diff in pull request #20306: [FLINK-28602][state/changelog] Close stream of StateChangeFsUploader normally while enabling compression

[GitBox]

rkhachatryan commented on code in PR #20306:
URL: https://github.com/apache/flink/pull/20306#discussion_r930161714


##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFsUploader.java:
##########
@@ -168,7 +168,7 @@ private UploadTasksResult upload(Path path, 
Collection<UploadTask> tasks) throws
                 wrappedStreamClosed = true;
             }
         } finally {
-            if (!wrappedStreamClosed) {
+            if (!wrappedStreamClosed || compression) {
                 fsStream.close();
             }

Review Comment:
   An alternative could be to remove
   ```
   OutputStream compressed =
           compression ? instance.decorateWithCompression(fsStream) : fsStream;
   ```
   
   Could you check if that causes the build to fail?



##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFsUploader.java:
##########
@@ -168,7 +168,7 @@ private UploadTasksResult upload(Path path, 
Collection<UploadTask> tasks) throws
                 wrappedStreamClosed = true;
             }
         } finally {
-            if (!wrappedStreamClosed) {
+            if (!wrappedStreamClosed || compression) {
                 fsStream.close();
             }

Review Comment:
   An alternative could be to remove
   ```
   OutputStream compressed =
           compression ? instance.decorateWithCompression(fsStream) : fsStream;
   ```
   
   Could you check if that causes the build to fail?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org