syhily commented on code in PR #19972: URL: https://github.com/apache/flink/pull/19972#discussion_r931803283
########## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/assigner/SplitAssignerFactory.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.pulsar.source.enumerator.assigner; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.connector.pulsar.source.config.SourceConfiguration; +import org.apache.flink.connector.pulsar.source.enumerator.PulsarSourceEnumState; +import org.apache.flink.connector.pulsar.source.enumerator.cursor.StopCursor; + +import org.apache.pulsar.client.api.SubscriptionType; + +import static org.apache.flink.connector.pulsar.source.enumerator.PulsarSourceEnumState.initialState; +import static org.apache.pulsar.client.api.SubscriptionType.Exclusive; +import static org.apache.pulsar.client.api.SubscriptionType.Failover; +import static org.apache.pulsar.client.api.SubscriptionType.Key_Shared; +import static org.apache.pulsar.client.api.SubscriptionType.Shared; + +/** The factory for creating split assigner. */ +@Internal +public final class SplitAssignerFactory { + + private SplitAssignerFactory() { + // No public constructor. + } + + /** Create blank assigner. */ + public static SplitAssigner create( + StopCursor stopCursor, SourceConfiguration sourceConfiguration) { + return create(stopCursor, sourceConfiguration, initialState()); + } + + /** Create assigner from checkpoint state. */ + public static SplitAssigner create( + StopCursor stopCursor, + SourceConfiguration sourceConfiguration, + PulsarSourceEnumState sourceEnumState) { + SubscriptionType subscriptionType = sourceConfiguration.getSubscriptionType(); + if (subscriptionType == Exclusive + || subscriptionType == Failover + || subscriptionType == Key_Shared) { + return new NormalSplitAssigner(stopCursor, sourceConfiguration, sourceEnumState); + } else if (subscriptionType == Shared) { + return new SharedSplitAssigner(stopCursor, sourceConfiguration, sourceEnumState); + } else { + throw new IllegalArgumentException( + "We don't support this subscription type: " + subscriptionType); + } Review Comment: I prefer `if else`. ########## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/cursor/start/MessageIdStartCursor.java: ########## @@ -43,23 +44,16 @@ public class MessageIdStartCursor implements StartCursor { * code</a> for understanding pulsar internal logic. * * @param messageId The message id for start position. - * @param inclusive Should we include the start message id in consuming result. + * @param inclusive Whether we include the start message id in consuming result. This works only + * if we provide a specified message id instead of {@link MessageId#earliest} or {@link + * MessageId#latest}. */ public MessageIdStartCursor(MessageId messageId, boolean inclusive) { Review Comment: I prefer using `inclusive` because it has been used in `StartCursor`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
