curcur commented on code in PR #20313:
URL: https://github.com/apache/flink/pull/20313#discussion_r934351551
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java:
##########
@@ -365,4 +401,18 @@ public String toString() {
return "EmptyDiscardStateObject{" + stateHandleID + '}';
}
}
+
+ private boolean preventsDiscardingCreatedCheckpoint(SharedStateEntry
entry) {
+ // explicitly set by the backend, e.g. private state is reused
Review Comment:
add that more documentation here: currently, changelog statebackend sets
this to true, and uses delayed deletion
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java:
##########
@@ -365,4 +401,18 @@ public String toString() {
return "EmptyDiscardStateObject{" + stateHandleID + '}';
}
}
+
+ private boolean preventsDiscardingCreatedCheckpoint(SharedStateEntry
entry) {
+ // explicitly set by the backend, e.g. private state is reused
+ if (entry.preventDiscardingCreatedCheckpoint) {
+ return true;
+ }
+ // with NO_SHARING strategy, shared state, if any, is bundled inside
the checkpoint folder
+ // noinspection RedundantIfStatement
Review Comment:
same here, add comments saying NO_SHARING indicates recover from a
savepoints, and explain why delay deletion is needd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
