lincoln-lil commented on code in PR #20393:
URL: https://github.com/apache/flink/pull/20393#discussion_r935658039
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalIncrementalGroupAggregate.scala:
##########
@@ -62,14 +62,19 @@ class StreamPhysicalIncrementalGroupAggregate(
inputRel: RelNode,
val partialAggGrouping: Array[Int],
val partialAggCalls: Array[AggregateCall],
- val finalAggGrouping: Array[Int],
Review Comment:
Do you mean the attribute name in `StreamPhysicalGroupAggregateBase`?
I was thinking the partial-final is the internal concept for two-phase
aggregate, so tend to omit the 'final' prefix in the base class which I think
can both represents
grouping in one-phase agg and distinguishes from partialGroupings in
two-phase agg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
