rkhachatryan commented on PR #20404: URL: https://github.com/apache/flink/pull/20404#issuecomment-1204559117
Thanks a lot for the fix @fredia Could you please briefly describe the root cause of the failure in the ticket? Besides of changing the source, this PR refactors the test setup. Ideally, refactoring should be a separate commit (with [hotfix] or [refactor] label). If it's a part of the fix, the message shouldn't be "refactor". In either case, could you please explain why the refactoring is necessary (e.g. in the commit message)? I'm also wondering whether `PeriodicMaterialization` part in test name is still relevant; if not, probably this PR is a good place to rename it. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
