[GitHub] [flink] Myracle commented on a diff in pull request #20361: [FLINK-27790][Table SQL / API] Port ADD JAR /SHOW JARS syntax implementation from SqlClient to TableEnvironment side

[GitBox]

Myracle commented on code in PR #20361:
URL: https://github.com/apache/flink/pull/20361#discussion_r935108846


##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/context/SessionContext.java:
##########
@@ -248,6 +248,7 @@ public static SessionContext create(DefaultContext 
defaultContext, String sessio
                 executionContext);
     }
 
+    // TODO: Only related to removeJar in test. Remove it once it has no use.

Review Comment:
   I add VisibleForTesting to addJar and listJar in SessionContext. Also, I 
move the related tests to tableEnv.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org