zhipeng93 commented on code in PR #139: URL: https://github.com/apache/flink-ml/pull/139#discussion_r943054862
########## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/kbinsdiscretizer/KBinsDiscretizerParams.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.feature.kbinsdiscretizer; + +import org.apache.flink.ml.param.IntParam; +import org.apache.flink.ml.param.Param; +import org.apache.flink.ml.param.ParamValidators; +import org.apache.flink.ml.param.StringParam; + +/** + * Params for {@link KBinsDiscretizer}. + * + * @param <T> The class type of this instance. + */ +public interface KBinsDiscretizerParams<T> extends KBinsDiscretizerModelParams<T> { Review Comment: Setting `HasSeed` has two possible indications: - Using same seed can have reproduciable outputs - Using different seed can have different outputs. However, our implementation does not provide reproduciable outputs due to the complexity of reproduciable distributed sampling --- We always provide different outputs in each run. As a result, it seems meaningless to provide `HasSeed` here. If we add `HasSeed` now, we may mislead users. However, we can add `HasSeed` later if we can provide reproduciable distributed sampling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
