maxCodeVector opened a new pull request, #20566:
URL: https://github.com/apache/flink/pull/20566
## What is the purpose of the change
This pull request solves the issue that the comment was lost when creating a
Table from Datastream and Schema. Previously, the method
`StreamTableEnvironment::fromDataStream` will ignore comments of the physical
columns defined in the schema. So all physical column comments will be lost.
Furthermore, `Table::as` will ignore comments of all the columns defined in the
schema when creating the new `ProjectQueryOperation`.
## Brief change log
- *Make sure the comment is added to the physical column when executing
`createConsumingResult()` in `SchemaTransaltor`*
- *When creatting the new `ProjectQueryOperation`, the new resolved schema
only creates from field name and field types which lost the comments again.
Make sure the comment is added in this step.*
## Verifying this change
This change added tests and can be verified as follows:
- *Added several tests in DataStreamJavaITCase*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): No
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: No
- The serializers: No
- The runtime per-record code paths (performance sensitive): No
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: No
- The S3 file system connector: No
## Documentation
- Does this pull request introduce a new feature? No.
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
