swuferhong commented on code in PR #20596:
URL: https://github.com/apache/flink/pull/20596#discussion_r950041925
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/abilities/SupportsDynamicFiltering.java:
##########
@@ -60,9 +60,16 @@
public interface SupportsDynamicFiltering {
/**
- * Applies the candidate filter fields into the table source, and return
the accepted fields.
- * The data corresponding the filter fields will be provided in runtime,
which can be used to
- * filter the partitions or the input data.
+ * Return the filter fields this partition table source supported. This
method is used in
+ * planner, which can be used to judge whether the source table is a
suitable partition table
+ * for filtering partitions.
Review Comment:
> /** * Returns the filter fields this partition table source supported.
This method can tell the * planner which fields can be used as dynamic
filtering fields, the planner will pick some * fields from the returned fields
based on the query, and create dynamic filtering operator. */
Done!
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/abilities/SupportsDynamicFiltering.java:
##########
@@ -60,9 +60,16 @@
public interface SupportsDynamicFiltering {
/**
- * Applies the candidate filter fields into the table source, and return
the accepted fields.
- * The data corresponding the filter fields will be provided in runtime,
which can be used to
- * filter the partitions or the input data.
+ * Return the filter fields this partition table source supported. This
method is used in
+ * planner, which can be used to judge whether the source table is a
suitable partition table
+ * for filtering partitions.
*/
- List<String> applyDynamicFiltering(List<String> candidateFilterFields);
+ List<String> listAcceptedFilterFields();
+
+ /**
+ * Applies the candidate filter fields into the table source. The data
corresponding the filter
+ * fields will be provided in runtime, which can be used to filter the
partitions or the input
+ * data.
+ */
Review Comment:
> /** * Applies the candidate filter fields into the table source. The data
corresponding the filter * fields will be provided in runtime, which can be
used to filter the partitions or the input * data. * * `<p>`NOTE: the candidate
filter fields are always from the result of {@link *
#listAcceptedFilterFields()}. */
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
