[GitHub] [flink] luoyuxia commented on a diff in pull request #18975: [FLINK-26474][hive] Fold exprNode to fix the issue of failing to call some hive udf required constant parameters with implicit constant passed

[GitBox]

luoyuxia commented on code in PR #18975:
URL: https://github.com/apache/flink/pull/18975#discussion_r950110721


##########
flink-connectors/flink-connector-hive/src/test/resources/query-test/udf.q:
##########
@@ -0,0 +1,13 @@
+-- SORT_QUERY_RESULTS
+
+select bround(55.0, -1);

Review Comment:
   I add a query `select bround(55.0, +1)` to cover the positive number with 
`+` sign.
   For the positive number with `+` sign, I think the query `select 
percentile_approx(x, 0.5) from foo` in `udaf.q` has covered it. 



##########
flink-connectors/flink-connector-hive/src/test/resources/query-test/udf.q:
##########
@@ -0,0 +1,13 @@
+-- SORT_QUERY_RESULTS
+
+select bround(55.0, -1);

Review Comment:
   I add a query `select bround(55.0, +1)` to cover the positive number with 
`+` sign.
   For the positive number without `+` sign, I think the query `select 
percentile_approx(x, 0.5) from foo` in `udaf.q` has covered it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org