Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2510#discussion_r79382611
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/AbstractIterativeTask.java
---
@@ -125,6 +125,16 @@ protected void initialize() throws Exception {
}
@Override
+ protected void postRun() throws Exception {
--- End diff --
The instanceof for ResettableDriver like
`if (this.driver instanceof ResettableDriver) {`
was being done in AbstractITerativetask. So I thought if we could clearly
seperate out what the finalize clause after every run() can do should be
differentiated based on the current instance executing it. Let BatchTask do
only driver.cleanup and let the AbstractIterativeTask do based on the type of
the driver. I can remove it if not needed. That was just for code clarity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
