[GitHub] [flink] wuchong commented on a diff in pull request #18975: [FLINK-26474][hive] Fold exprNode to fix the issue of failing to call some hive udf required constant parameters with implicit constant passed

[GitBox]

wuchong commented on code in PR #18975:
URL: https://github.com/apache/flink/pull/18975#discussion_r958423656


##########
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectQueryITCase.java:
##########
@@ -788,7 +788,7 @@ public void testCastTimeStampToDecimal() throws Exception {
                                                     timestamp))
                                     .collect());
             assertThat(results.toString())
-                    .isEqualTo(String.format("[+I[%s]]", 
expectTimeStampDecimal.toFormatString(8)));
+                    .isEqualTo(String.format("[+I[%s]]", 
expectTimeStampDecimal));

Review Comment:
   Is there any reason for this change? IIUC, the `toFormatString(8)` is on 
purpose because it is cast to `decimal(30,8)`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org