mxm commented on code in PR #20485:
URL: https://github.com/apache/flink/pull/20485#discussion_r963034437


##########
flink-core/src/main/java/org/apache/flink/configuration/PipelineOptions.java:
##########
@@ -282,4 +282,21 @@ public enum VertexDescriptionMode {
                     .withDescription(
                             "Whether name of vertex includes topological index 
or not. "
                                     + "When it is true, the name will have a 
prefix of index of the vertex, like '[vertex-0]Source: source'. It is false by 
default");
+
+    @PublicEvolving
+    public static final ConfigOption<Boolean> ALLOW_UNALIGNED_SOURCE_SPLITS =
+            key("pipeline.watermark-alignment.allow-unaligned-source-splits")
+                    .booleanType()
+                    .defaultValue(false)

Review Comment:
   I think we are on the same page. With only FLIP 217, a slow and a fast split 
in the same operator instance will pause both the fast and the slow split. That 
likely means the gap between the two splits will not become smaller but bigger 
or remain the same. The lag behavior is very much random.
   
   At the least, we should provide good error reporting in case a user wants to 
use a source without split alignment. The error report should also inform the 
user how to override this behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to