[ https://issues.apache.org/jira/browse/FLINK-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507001#comment-15507001 ]
ASF GitHub Bot commented on FLINK-4248: --------------------------------------- Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2303#discussion_r79651336 --- Diff: flink-core/src/test/java/org/apache/flink/types/parser/SqlTimeParserTest.java --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + +package org.apache.flink.types.parser; + + +import java.sql.Time; + +public class SqlTimeParserTest extends ParserTestBase<Time> { + + @Override + public String[] getValidTestValues() { + return new String[] { + "00:00:00", "02:42:25", "14:15:51", "18:00:45", "23:59:58", "0:0:0" + }; + } + + @Override + public Time[] getValidTestResults() { + return new Time[] { + Time.valueOf("00:00:00"), Time.valueOf("02:42:25"), Time.valueOf("14:15:51"), + Time.valueOf("18:00:45"), Time.valueOf("23:59:58"), Time.valueOf("0:0:0") + }; + } + + @Override + public String[] getInvalidTestValues() { + return new String[] { + " 00:00:00", "00:00:00 ", "00:00::00", "00x00:00", "2013/08/12", " ", "\t" --- End diff -- This is also not invalid. The seconds are converted to minutes. > CsvTableSource does not support reading SqlTimeTypeInfo types > ------------------------------------------------------------- > > Key: FLINK-4248 > URL: https://issues.apache.org/jira/browse/FLINK-4248 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Affects Versions: 1.1.0 > Reporter: Till Rohrmann > Assignee: Timo Walther > > The Table API's {{CsvTableSource}} does not support to read all Table API > supported data types. For example, it is not possible to read > {{SqlTimeTypeInfo}} types via the {{CsvTableSource}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)