[ 
https://issues.apache.org/jira/browse/FLINK-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509871#comment-15509871
 ] 

ASF GitHub Bot commented on FLINK-3580:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2468#discussion_r79824678
  
    --- Diff: docs/dev/table_api.md ---
    @@ -1578,6 +1578,17 @@ localTimestamp()
           </td>
         </tr>
     
    +    <tr>
    +      <td>
    +        {% highlight java %}
    +temporalOverlaps(TIMEPOINT, TEMPORAL, TIMEPOINT, TEMPORAL)
    +{% endhighlight %}
    +      </td>
    +      <td>
    +        <p>Determines whether two anchored time intervals overlap. It 
evaluates <code>leftTemporal >= rightTimePoint && rightTemporal >= 
leftTimePoint</code>. E.g. <code>temporalOverlaps("2:55:00".toTime, 1.hour, 
"3:30:00".toTime, 2.hour)</code> leads to true.</p>
    --- End diff --
    
    I think the condition is hard to understand because it is not clear what a 
`Temporal` is. How about we say that time point and temporal are transformed 
into a range defined by two timestamps (start, end) and give the condition as 
`leftEnd >= rightStart && rightEnd >= leftStart`?


> Reintroduce Date/Time and implement scalar functions for it
> -----------------------------------------------------------
>
>                 Key: FLINK-3580
>                 URL: https://issues.apache.org/jira/browse/FLINK-3580
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>
> This task includes:
> {code}
> DATETIME_PLUS
> EXTRACT_DATE
> FLOOR
> CEIL
> CURRENT_TIME
> CURRENT_TIMESTAMP
> LOCALTIME
> LOCALTIMESTAMP
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to