tweise opened a new pull request, #385:
URL: https://github.com/apache/flink-kubernetes-operator/pull/385
## What is the purpose of the change
Automatically set jobId for Flink version < 1.16 to avoid conflicts in
checkpoint path (and other jobId based effects).
TODO:
* Unit test
* This breaks stateful upgrade if the CRD is not updated
* We may want a better way to accommodate this in the status in the future
rather than adding individual fields. Should we add a map that can be used for
various purposes?
## Brief change log
* Set a jobId when no jobID is defined by user and Flink version is < 1.16.
* Rotate jobId when upgrade mode is stateless
## Verifying this change
TODO: This change added tests and can be verified as follows:
Manual verification:
* No jobId set in Flink config
* Set upgrade mode to stateless. Trigger CR changes and check that every
redeploy uses a new ID.
* Set upgrade mode to last_state. Thrigger CR changes and check that
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
(**yes** / no)
- Core observer or reconciler logic that is regularly executed: (yes / no)
Field added to status and CRD needs to be updated for this change to work.
If the CRD is not updated, the last state upgrade mode breaks.
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
