gyfora commented on code in PR #377:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/377#discussion_r985697814
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -97,6 +100,8 @@ public final void reconcile(CR cr, Context<?> ctx) throws
Exception {
return;
}
+ setOwnerReference(cr, deployConfig);
+
Review Comment:
I think we should call this method from inside the `deploy` method otherwise
the ownerreference might not be set correctly during rollbacks, restarts etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
