pnowojski commented on code in PR #20233:
URL: https://github.com/apache/flink/pull/20233#discussion_r988586042
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java:
##########
@@ -209,6 +213,7 @@ class SubtaskCheckpointCoordinatorImpl implements
SubtaskCheckpointCoordinator {
this.prepareInputSnapshot = prepareInputSnapshot;
this.abortedCheckpointIds =
createAbortedCheckpointSetWithLimitSize(maxRecordAbortedCheckpoints);
+ this.maxRecordAbortedCheckpoints = maxRecordAbortedCheckpoints;
Review Comment:
> Could we always use the max concurrent checkpoints and remove the
SubtaskCheckpointCoordinatorImpl#DEFAULT_MAX_RECORD_ABORTED_CHECKPOINTS?
I think so.
> why need the
SubtaskCheckpointCoordinatorImpl#DEFAULT_MAX_RECORD_ABORTED_CHECKPOINTS? Why
don't use the max concurrent checkpoints here?
Probably because when it was being implemented by Myasuka (Yun Tang) and
reviewed by me 2 years ago, we haven't figured out this trick with using `max
concurrent checkpoints` :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
