MartijnVisser commented on code in PR #20997:
URL: https://github.com/apache/flink/pull/20997#discussion_r990828362


##########
flink-connectors/flink-sql-connector-hive-2.3.9/pom.xml:
##########
@@ -48,7 +45,7 @@ under the License.
                <dependency>
                        <groupId>org.apache.hive</groupId>
                        <artifactId>hive-exec</artifactId>
-                       <version>2.3.9</version>
+                       <version>3.1.3</version>

Review Comment:
   @ren-jq101 Thanks for the PR, but doesn't make much sense to update both 
connectors to version 3.1.3. Next to that, updating the version numbers is not 
enough. Since this would effectively drop version 2.3.9 from the codebase, a 
discussion and vote needs to happen for that on the mailing list. If that vote 
would pass, there's more then just a version bump in the POM required. It 
definitely requires changes to the license NOTICE files plus there could be 
potential code changes required too. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to