[
https://issues.apache.org/jira/browse/FLINK-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516273#comment-15516273
]
ASF GitHub Bot commented on FLINK-4670:
---------------------------------------
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2543
Hi, till. Thanks for your review.
First sorry to bind to the wrong jira link, already correct it.
About heartbeatManager, i thought we could separate HeartbeatManager into
two part, each part focus only on one function.
1. Death watch to monitor liveness, it could register watch, unregister
watch, and notify the dead targets. just like deathwatch in akka. Although now
I implement it on Akka's dead watch functionality, but interface is defined.
It's fine to give another implementation of it in future.
2. Payload deliver periodically. But because data sync behavior is
different in different component, e.g, TM,JM,RM, so I'm not sure it is good to
extract the logic into a common logic.
> Add watch mechanism on current RPC framework
> --------------------------------------------
>
> Key: FLINK-4670
> URL: https://issues.apache.org/jira/browse/FLINK-4670
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: zhangjing
> Assignee: zhangjing
> Fix For: 1.2.0
>
>
> Add watch mechanism on current RPC framework so that RPC gateway could be
> watched to make sure the rpc server is running just like previous DeathWatch
> in akka
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
