twalthr commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r993330634
########## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/catalog/JavaCatalogTableTest.xml: ########## @@ -76,12 +75,11 @@ LogicalProject(EXPR$0=[$0]) </Resource> <Resource name="optimized exec plan"> <![CDATA[ -GroupWindowAggregate(window=[TumblingGroupWindow('w, proctime, 600000)], select=[COUNT($f3) AS EXPR$0]) +GroupWindowAggregate(window=[TumblingGroupWindow('w, proctime, 600000)], select=[COUNT(*) AS EXPR$0]) Review Comment: I don't fully understand what has changed. Somehow fields are not part of agg call anymore? we need to check if this is a pure logical node change or whether this also affects the structure of exec nodes. exec nodes need a stable JSON ser/de logic. I will try to help with this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org